chore: exclude tests from library packaging#193
Open
HenriTEL wants to merge 1 commit intoRunware:mainfrom
Open
chore: exclude tests from library packaging#193HenriTEL wants to merge 1 commit intoRunware:mainfrom
HenriTEL wants to merge 1 commit intoRunware:mainfrom
Conversation
In addition to have a cleaner package, those changes avoid conflicts when library users have a `tests/` directory with no `__init__.py`. In such case python tries to import things in the `tests` package the sdk provides currently.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the packaging configuration so the SDK no longer ships its internal tests package, preventing import conflicts for downstream users who also have a tests/ directory.
Changes:
- Exclude the
testspackage fromsetuptools.find_packages()during distribution builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "Issue tracker": "https://github.com/runware/sdk-python/issues", | ||
| }, | ||
| packages=find_packages(), | ||
| packages=find_packages(exclude=("tests",)), |
There was a problem hiding this comment.
find_packages(exclude=("tests",)) only excludes the top-level tests package; any subpackages like tests.unit would still be included if added later. Consider excluding both tests and tests.* to ensure the entire tests package tree is never packaged.
Suggested change
| packages=find_packages(exclude=("tests",)), | |
| packages=find_packages(exclude=("tests", "tests.*")), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to a cleaner package, those changes avoid conflicts when users have a
tests/directory with no__init__.py.In such case python tries to import things in the
testspackage the sdk provides currently.